<html>
<head><meta charset="utf-8"><title>inherit stable annotations in enum varian… compiler-team#370 · t-compiler/major changes · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/index.html">t-compiler/major changes</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html">inherit stable annotations in enum varian… compiler-team#370</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213300886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213300886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213300886">(Oct 14 2020 at 14:55)</a>:</h4>
<p>A new proposal has been announced: <a href="https://github.com/rust-lang/compiler-team/issues/370">inherit stable annotations in enum variants and field items #370</a>. It will be announced at the next meeting to try and draw attention to it, but usually MCPs are not discussed during triage meetings. If you think this would benefit from discussion amongst the team, consider proposing a design meeting.</p>



<a name="213300895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213300895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213300895">(Oct 14 2020 at 14:55)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="492">@T-compiler</span>: Proposal <a href="https://github.com/rust-lang/compiler-team/issues/370#issuecomment-708458205">#370</a> has been seconded, and will be approved in 10 days if no objections are raised.</p>



<a name="213310018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213310018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213310018">(Oct 14 2020 at 15:47)</a>:</h4>
<blockquote>
<p>it is quite unusual to have a stable struct/enum with public fields that are unstable</p>
</blockquote>
<p>It used to be <em>very</em> common to have a public enum with an unstable variant, but thankfully <code>#[non_exhaustive]</code> has removed essentially all of those.</p>



<a name="213310952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213310952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213310952">(Oct 14 2020 at 15:53)</a>:</h4>
<p>As an example of a case where I could see wanting unstable-in-stable, I've pondered adding <a href="https://llvm.org/docs/Atomics.html#unordered">Unordered</a> to <code>sync::atomic::Ordering</code>, which would probably want to be unstable for a while.</p>
<p>So I like this for reduced annotation burden, but it would be nice to have a "reviewer checklist of things to look for in PRs adding something that's supposed to be unstable" somewhere.</p>



<a name="213329701"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213329701" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213329701">(Oct 14 2020 at 18:02)</a>:</h4>
<p>/me has long wanted a bot that tells me "hey you're adding X Y Z to stable surface area"</p>



<a name="213329840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213329840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213329840">(Oct 14 2020 at 18:03)</a>:</h4>
<p><a href="https://github.com/rust-dev-tools/rust-semverver/">https://github.com/rust-dev-tools/rust-semverver/</a></p>



<a name="213329880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213329880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213329880">(Oct 14 2020 at 18:03)</a>:</h4>
<p>might be painful to get it to work with bootstrap though</p>



<a name="213359911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213359911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213359911">(Oct 14 2020 at 22:48)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> one note -- we recently had a conversation about mcps and how contentious ones would be better approved via FCP rather than the "Seconding" process. I think there has certainly been enough back and forth here for that to be merited here.</p>



<a name="213359921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/213359921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#213359921">(Oct 14 2020 at 22:48)</a>:</h4>
<p>(Though I am personally fine with this)</p>



<a name="215723767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/233931-t-compiler/major%20changes/topic/inherit%20stable%20annotations%20in%20enum%20varian%E2%80%A6%20compiler-team%23370/near/215723767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/233931-t-compiler/major-changes/topic/inherit.20stable.20annotations.20in.20enum.20varian.E2.80.A6.20compiler-team.23370.html#215723767">(Nov 05 2020 at 15:05)</a>:</h4>
<p>This proposal has been accepted: <a href="https://github.com/rust-lang/compiler-team/issues/370">#370</a>.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>